Repository navigation
Import prebuilt example bundles instead of building here again - #329
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8e627e8d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
AGulev
left a comment
AGulev
left a comment
There was a problem hiding this comment.
Two P2 issues remain in the snapshot importer: incomplete bundles can be accepted, and imports without --download can combine bundles and source from different revisions. Both were reproduced with fixture archives using the real WASM deduplication and stripping code; the added unit test and current GitHub CI pass.
This updates the website to use example bundles built by the
examplesrepo CI, instead of building all examples again during the website update.The website downloads the bundle snapshot and imports documentation from the matching examples revision.
If the snapshot is missing or invalid, the update will fail and the previously published site will be there unchanged.
This depends on defold/examples#247 that must be merged first